feat: Comparing different types returns null #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an expression compares two values of different types then the evaluation returns null and reports a failure. Previously, the evaluation failed with an error. The new behavior is aligned with the DMN specification and helps users to handle these cases.
If a unary-test expression compares the input value with a value of a different type then the evaluation returns null and reports an error. Previously, the evaluation failed with an error.
Adjust the test cases to expect `null` as the result of the evaluation. Previously, the evaluation failed in these cases.
The evaluation of the unary-tests expression doesn't fail anymore. Instead, it returns null.
saig0
force-pushed
the
708-compare-different-types
branch
from
86f273f
to
657112c
Compare
|
@nicpuppa please review this new PR in the next few days. It is again about being more full-friendly - this time when comparing values of different types. 🍪 |
nicpuppa
approved these changes
Sep 14, 2023
src/test/scala/org/camunda/feel/impl/interpreter/ComparisonTypeTest.scala
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If an expression or a unary-test compares two values of different types then the evaluation returns null and reports a failure. Previously, the evaluation failed with an error.
The new behavior is aligned with the DMN specification and helps users to handle these cases.
Related issues
closes #708