Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Return null on accessing a non-existing property #709

Merged
merged 3 commits into from
Sep 13, 2023

Conversation

saig0
Copy link
Member

@saig0 saig0 commented Sep 11, 2023

Description

Change the behavior for accessing a non-existing property. Instead of failing the evaluation, it returns null. A failure with a descriptive message is reported.

This change is aligned with the DMN specification and the new direction to be more null-friendly.

Related issues

closes #707

Change the expected behavior if an expression access a non-existing property. Instead of failing the evaluation, it should return null.
Change the behavior for accessing a non-existing property. Instead of failing the evaluation, it returns null instead. A failure with a descriptive message is reported.

This change is aligned with the DMN specification and the new direction to be more null-friendly.
@saig0 saig0 requested a review from nicpuppa September 11, 2023 11:12
@saig0
Copy link
Member Author

saig0 commented Sep 11, 2023

@nicpuppa here is a small PR for you. It is related to the other topics recently. Please have a look in the next few days. Thank you! 🍪

Copy link
Contributor

@nicpuppa nicpuppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 💪

Keep it going with the tests refactor ❤️

@saig0 saig0 merged commit 88234a5 into main Sep 13, 2023
3 checks passed
@saig0 saig0 deleted the 707-non-existing-property branch September 13, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The access of a non-existing property should return null
2 participants