feat: Make failure messages more readable #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saig0
force-pushed
the
713-reable-failure-messages
branch
from
5ae2a19
to
4f7794d
Compare
|
@nicpuppa I improved the failure messages as a follow-up from our last PR. Please have a look. 🍪 |
Copy the existing string representation logic of the `string()` function into the value types.
Replace the custom string representation logic of the `string()` function with the `toString()` method of the types.
Uniform the failure messages. Add missing failure types.
The functions `andThen()` and `compose()` are auto-generated by Scala. We can ignore changes on these functions.
saig0
force-pushed
the
713-reable-failure-messages
branch
from
4f7794d
to
269a60f
Compare
nicpuppa
approved these changes
Sep 19, 2023
src/main/scala/org/camunda/feel/impl/builtin/ConversionBuiltinFunctions.scala
Show resolved
Hide resolved
| ) | ||
| } | ||
|
|
||
| it should "report a suppressed failure if an addition has incompatible values" in { | ||
| evaluateExpression("2 + true") should reportFailure( | ||
| failureType = EvaluationFailureType.INVALID_TYPE, | ||
| failureMessage = "Expected Number but found 'ValBoolean(true)'" | ||
| failureMessage = "Expected number but found 'true'" |
There was a problem hiding this comment.
❓ How this is possible ? 🪄
Number -> number
There was a problem hiding this comment.
I aligned the failure messages and changed the type names to start with a lowercase. See here. 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
string()function into the value types.Related issues
closes #713