feat(builtin): add partition function #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lzgabel awesome. Thank you for your contribution. 🎉 I'll review your changes in the next few days. Please take a look at the contribution guidelines and check if you followed the guide. 👀 |
lzgabel
force-pushed
the
feature/881-lz-partition-function
branch
from
33ff252
to
7d56a15
Compare
saig0
requested changes
Nov 15, 2024
src/main/scala/org/camunda/feel/impl/builtin/ListBuiltinFunctions.scala
Outdated
Show resolved
Hide resolved
src/test/scala/org/camunda/feel/impl/builtin/BuiltinListFunctionsTest.scala
Show resolved
Hide resolved
src/test/scala/org/camunda/feel/impl/builtin/BuiltinListFunctionsTest.scala
Outdated
Show resolved
Hide resolved
lzgabel
force-pushed
the
feature/881-lz-partition-function
branch
from
7d56a15
to
75aa418
Compare
|
Hi @saig0. I have applied your suggestions and squashed the commits. Please check this out. 🙇 |
saig0
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
@lzgabel LGTM. Great work! 🚀
Please follow up and add the new function to the C8 documentation. Refer to the guidelines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
partition(list, size).sizeargument.Related issues
closes #881