Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use core gene model from VRS 2.x, update to Pydantic v2 #132

Closed
jsstevenson opened this issue Sep 28, 2023 · 4 comments
Closed

Use core gene model from VRS 2.x, update to Pydantic v2 #132

jsstevenson opened this issue Sep 28, 2023 · 4 comments
Labels
priority:high High priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup"

Comments

@jsstevenson
Copy link
Member

It'll be easier for all of our brains if we can move the fusions work up to 2.x. I don't think this strictly blocks that but it'd be good to try to be consistent if possible.
@jsstevenson jsstevenson added priority:high High priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup" labels Sep 28, 2023
@jsstevenson jsstevenson changed the title Use core gene model from VRS 2.x Use core gene model from VRS 2.x, update to Pydantic v2 Oct 17, 2023
@jsstevenson
Copy link
Member Author

jsstevenson commented Oct 17, 2023 •
edited
Loading

This is now priority:even higher because it's blocking @katiestahl on the gene transcripts suggestion issue

@katiestahl katiestahl self-assigned this Oct 18, 2023
@katiestahl katiestahl mentioned this issue Oct 18, 2023
Merged
@jsstevenson
Copy link
Member Author

jsstevenson commented Jan 22, 2024 •
edited
Loading

Edit: intentions are to integrate the VRS 2.x object model into FUSOR and drop VRSATILE-style descriptor models.

@jsstevenson
Copy link
Member Author

#130 is associated with this

@korikuzma
Copy link
Member

I think this will be done in #95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority:high High priority technical debt A feature/requirement implemented in a sub-optimal way & must be re-written. Contrast to "cleanup"
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jsstevenson @katiestahl @korikuzma