Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest gene-normalizer version #170

Open
jsstevenson opened this issue Jul 29, 2024 · 1 comment
Open

Update to latest gene-normalizer version #170

jsstevenson opened this issue Jul 29, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request priority:medium Medium priority

Comments

@jsstevenson
Copy link
Member

jsstevenson commented Jul 29, 2024

Feature description

#166 pins a recent gene normalizer version, but it's incompatible with the latest version. We should handle those incompatibilities and update.

Specifically, the issue to handle revolves around the CURIE root object/regex pattern that we import from there.

Use case

n/a

Proposed solution

No response

Alternatives considered

No response

Implementation details

No response

Potential Impact

No response

Additional context

No response

Contribution

None

@jsstevenson jsstevenson added enhancement New feature or request priority:medium Medium priority labels Jul 29, 2024
@katiestahl
Copy link
Contributor

katiestahl commented Sep 16, 2024

additional context before I forget: the most recent version removes the CURIE, which we use, so we may need to add a type to fusor? (James mentioned this already in the main body of this ticket) But I need to look into where we still use CURIEs since I know in some places, we wanted to steer toward using strings instead, depending on what remaining things we're using CURIEs for

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:medium Medium priority
Projects
None yet
Development

No branches or pull requests

2 participants