-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mlflow secret used for seldon is not working (seldon-init-container-secret) #429
Comments
The workaround is to apply manually a secret with proper values to the namespace the inference will be done in. |
To replicate the issue:
To fix it, apply the working secret above and your deployment should work. |
@Barteus looking at this now. I see the issue raised but am not sure what your desired behaviour is from a fix. If someone has
In your example that you ran (sorry, end of day so I'll actually run it myself tomorrow), are you creating Thoughts? |
I did try to replicate this today but was unsuccessful. Having a Juju bundle could help in general with reducing the amount of time needed to replicate and confirm so that more time can be spent actually fixing the issue. Here are the steps that I took:
|
Summary of my understanding before I make any fixes Current stateAny At time of writing, out Desired statesSome different desired states (they overlap a little and easier to write as separate thing that ideally would all be combined):
Some potentially useful things
Next stepsNear termAchieving desired state (1) is tricky because we lack a way of putting secrets into all user namespaces. As an interim step, it is proposed that we update the Medium termIf we get a way to publish secrets to all namespaces (KF-220, upstream, or otherwise), we should:
Between these two things, users would then in their own namespace be able to deploy Long termThought is needed to determine how we could implement something like the medium term solution but where every user's |
The Near Term solution is up for review in canonical/mlflow-operator#27, and a gist of how I tested with it (following @Barteus's notebook pretty closely) is here. Note that when I tried to use that gist today though, there was a package conflict between mlflow/whatever else is needed in the deployment. To get it to work I had to manually edit the Update: I think the |
Re the
This overrides the default mlflowserver version |
Deployed Kiubeflow 1.6 and MLFlow.
Created Seldon secret based on the above and added it to user's namespace:
Create/deploy Seldon deployment with
At this point the solution fails. The following errors are observed in classifier initialisation container:
Endpoint is incorrectly encoded. Need to add namespace in URL encoding. |
canonical/bundle-kubeflow#429 Summary of changes: - Added namespace to endpoint URL encoding. - Added integration testing.
canonical/bundle-kubeflow#429 Summary of changes: - Updated libs. - Updated ops (removed pinning).
canonical/bundle-kubeflow#429 Summary of changes: - Modified integrate.yaml to include K8S v1.22, setup controller with pinned version.
canonical/bundle-kubeflow#429 Summary of changes: - Fixed integration tests.
canonical/bundle-kubeflow#429 Summary of changes: - Fixed integration tests.
To verify:
Decoded base64
Create/deploy Seldon deployment with
Initialisation container successfully created S3 bucket using the above secret:
No model to transfer, that's why bytes transferred are zero. However, access to S3 is successful. |
Fix is merged: canonical/mlflow-operator#58 |
This issue can be closed. |
When seldon-init-container-secret is used to deploy the model from minio the credentials passed to the RCLONE in init container are wrong. The Pod is going into the status Init:CrashLoopBackOff
Log from init container:
Expected log from init container (removed not relevant sections):
Working secret.yaml:
Deployment example.yaml:
For more info about RCLONE auth configuration:
The text was updated successfully, but these errors were encountered: