Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip building integration test environment when we have no rock integration tests #46

Open
ca-scribner opened this issue Feb 13, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@ca-scribner
Copy link
Contributor

Context

Many of our rocks have no integration tests but they still build a test environment:

https://github.com/canonical/charmed-kubeflow-workflows/blob/main/.github/workflows/integration-test-rock.yaml#L90:L97

For a rock that has no integration test, this adds ~5 min to the workflow execution that is wasted. Can we detect whether we have integration tests, and skip this step if we dont?

What needs to get done

  1. implement a check for integration tests
  2. skip integration tests if we don't have any

Definition of Done

  1. update the integration workflow and ensure it works on our rocks
@ca-scribner ca-scribner added the enhancement New feature or request label Feb 13, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5341.

This message was autogenerated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant