Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chip Tool tests not using the snap built from the PR #34

Closed
farshidtz opened this issue Jan 18, 2024 · 0 comments · Fixed by #36
Closed

Chip Tool tests not using the snap built from the PR #34

farshidtz opened this issue Jan 18, 2024 · 0 comments · Fixed by #36
Labels
bug Something isn't working CI Continuous Integration

Comments

@farshidtz
Copy link
Member

The test action doesn’t pass the local snap’s path to the tests. As a result, the tests run against the Chip Tool downloaded from the store.

Original PR where this issue was overlooked: canonical/matter-snap-testing#2

Relevant code: https://github.com/canonical/matter-snap-testing/blob/0f3c7fc001768aa541f8543bef1045d056aff033/test/action.yml#L44-L73

Example workflow logs showing that the snap was installed from the store: https://github.com/canonical/chip-tool-snap/actions/runs/7540266663/job/20524800647#step:2:101
@farshidtz farshidtz added bug Something isn't working CI Continuous Integration labels Jan 18, 2024
@farshidtz farshidtz mentioned this issue Jan 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working CI Continuous Integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Chip Tool snap tests canonical/chip-tool-snap
1 participant
@farshidtz