-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe method of updating images references and version when updating Istio #324
Comments
I will add that, for istio-pilot at least, it's not only image references but all the values set in the default config introduced here. |
This was referenced Aug 31, 2023
i-chvets
added a commit
that referenced
this issue
Aug 31, 2023
# Description More details in: #322 The changes in this PR are based on work done in #316 Created a new PR to simplify workflow. # Summary of changes: - Modified code to use --set to alter precompile istioctl manifests to allow changes according to charm configuration. - Added `image-configuration` option to istio-pilot `config.yaml` - Added `proxy-image` option to istio-gatewat `config.yaml` - Added unit test for testing helper that retrieves configuration. # Testing For complete testing refer to #322 Related PR: #320 NOTE: Created [issue](#324) to track updates to process of updating Istio.
For our airgapped effort, we'll use a static list for now due to time constraints and will revisit this to do it dynamically in the next CKF release. |
i-chvets
added a commit
that referenced
this issue
Sep 25, 2023
# Description More details in: #322 The changes in this PR are based on work done in #316 Created a new PR to simplify workflow. # Summary of changes: - Modified code to use --set to alter precompile istioctl manifests to allow changes according to charm configuration. - Added `image-configuration` option to istio-pilot `config.yaml` - Added `proxy-image` option to istio-gatewat `config.yaml` - Added unit test for testing helper that retrieves configuration. # Testing For complete testing refer to #322 Related PR: #320 NOTE: Created [issue](#324) to track updates to process of updating Istio.
i-chvets
added a commit
that referenced
this issue
Sep 25, 2023
# Description More details in: #322 The changes in this PR are based on work done in #316 Created a new PR to simplify workflow. # Summary of changes: - Modified code to use --set to alter precompile istioctl manifests to allow changes according to charm configuration. - Added `image-configuration` option to istio-pilot `config.yaml` - Added `proxy-image` option to istio-gatewat `config.yaml` - Added unit test for testing helper that retrieves configuration. # Testing For complete testing refer to #322 Related PR: #320 NOTE: Created [issue](#324) to track updates to process of updating Istio.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
istioctl
binary is used to install Istio in Istio charms. Up until this update there was no method to specify which Istio images to use in deployment. After the above update there is a need for specification/description on where to look for image names and versions when updating Istio. I.e. where in upstream Istio project those can be found.Configuration option for image that requires attention in the documentation:
The text was updated successfully, but these errors were encountered: