Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe method of updating images references and version when updating Istio #324

Open
i-chvets opened this issue Aug 31, 2023 · 2 comments

Comments

@i-chvets
Copy link
Contributor

i-chvets commented Aug 31, 2023

Description

istioctl binary is used to install Istio in Istio charms. Up until this update there was no method to specify which Istio images to use in deployment. After the above update there is a need for specification/description on where to look for image names and versions when updating Istio. I.e. where in upstream Istio project those can be found.

Configuration option for image that requires attention in the documentation:

  image-configuration:
    default: |
      pilot-image: 'pilot'  # values.pilot.image
      global-tag: '1.17.3'  # values.global.tag
      global-hub: 'docker.io/istio' # values.global.hub
      global-proxy-image: 'proxyv2' # values.global.proxy.image
      global-proxy-init-image: 'proxyv2' # values.global.proxy_init.image
      grpc-bootstrap-init: 'busybox:1.28'
    description: >
      YAML or JSON formatted input defining image configuration to use when installing the Istio control plane.
      For reference https://istio.io/v1.5/docs/reference/config/installation-options/
    type: string
@orfeas-k
Copy link
Contributor

I will add that, for istio-pilot at least, it's not only image references but all the values set in the default config introduced here.

i-chvets added a commit that referenced this issue Aug 31, 2023
# Description
More details in: #322
The changes in this PR are based on work done in #316
Created a new PR to simplify workflow.

# Summary of changes:
- Modified code to use --set to alter precompile istioctl manifests to allow changes according to charm configuration.
- Added `image-configuration` option to istio-pilot `config.yaml`
- Added `proxy-image` option to istio-gatewat `config.yaml`
- Added unit test for testing helper that retrieves configuration.

# Testing

For complete testing refer to #322

Related PR: #320

NOTE: Created [issue](#324) to track updates to process of updating Istio.
@NohaIhab
Copy link
Contributor

NohaIhab commented Sep 4, 2023

For our airgapped effort, we'll use a static list for now due to time constraints and will revisit this to do it dynamically in the next CKF release.

i-chvets added a commit that referenced this issue Sep 25, 2023
# Description
More details in: #322
The changes in this PR are based on work done in #316
Created a new PR to simplify workflow.

# Summary of changes:
- Modified code to use --set to alter precompile istioctl manifests to allow changes according to charm configuration.
- Added `image-configuration` option to istio-pilot `config.yaml`
- Added `proxy-image` option to istio-gatewat `config.yaml`
- Added unit test for testing helper that retrieves configuration.

# Testing

For complete testing refer to #322

Related PR: #320

NOTE: Created [issue](#324) to track updates to process of updating Istio.
i-chvets added a commit that referenced this issue Sep 25, 2023
# Description
More details in: #322
The changes in this PR are based on work done in #316
Created a new PR to simplify workflow.

# Summary of changes:
- Modified code to use --set to alter precompile istioctl manifests to allow changes according to charm configuration.
- Added `image-configuration` option to istio-pilot `config.yaml`
- Added `proxy-image` option to istio-gatewat `config.yaml`
- Added unit test for testing helper that retrieves configuration.

# Testing

For complete testing refer to #322

Related PR: #320

NOTE: Created [issue](#324) to track updates to process of updating Istio.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants