Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-5591] refactor: Rework status handling #254

Merged
merged 13 commits into from
Nov 13, 2024
Merged

Conversation

Batalex
Copy link
Contributor

@Batalex Batalex commented Oct 14, 2024

See the list of changes in canonical/kafka-k8s-operator#141

Scenario's boilerplate setup takes longer to run than Harness'. I had to increase the unit test job timeout limit from 5 to 10 minutes.

@Batalex Batalex force-pushed the feat/dpe-5591-status branch from 2436552 to 89bc50f Compare October 14, 2024 09:10
@Batalex Batalex changed the title Feat/dpe 5591 status [DPE-5591] Rework status handling Oct 14, 2024
@Batalex Batalex force-pushed the feat/dpe-5591-status branch 2 times, most recently from ef85303 to be262b2 Compare October 14, 2024 14:42
@Batalex Batalex self-assigned this Oct 15, 2024
@Batalex Batalex force-pushed the feat/dpe-5591-status branch from e7fafd3 to 0784ed4 Compare October 17, 2024 07:15
@Batalex Batalex force-pushed the feat/dpe-5591-status branch from 499a4cc to 554d0ef Compare October 25, 2024 13:10
src/events/broker.py Outdated Show resolved Hide resolved
@Batalex Batalex force-pushed the feat/dpe-5591-status branch 2 times, most recently from 4f0ea3d to e4548db Compare October 30, 2024 16:05
@Batalex Batalex marked this pull request as ready for review October 31, 2024 14:32
Copy link
Contributor

@deusebio deusebio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! As already provided in the original PR

@Batalex Batalex force-pushed the feat/dpe-5591-status branch from d52312e to 92f9495 Compare November 12, 2024 15:44
@Batalex Batalex changed the title [DPE-5591] Rework status handling [DPE-5591] refactor: Rework status handling Nov 13, 2024
@Batalex Batalex merged commit fe4b61c into main Nov 13, 2024
22 of 23 checks passed
@Batalex Batalex deleted the feat/dpe-5591-status branch November 13, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants