generated from canonical/template-operator
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPE-5591] refactor: Rework status handling #254
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Batalex
force-pushed
the
feat/dpe-5591-status
branch
from
October 14, 2024 09:10
2436552
to
89bc50f
Compare
Batalex
force-pushed
the
feat/dpe-5591-status
branch
2 times, most recently
from
October 14, 2024 14:42
ef85303
to
be262b2
Compare
Batalex
force-pushed
the
feat/dpe-5591-status
branch
from
October 17, 2024 07:15
e7fafd3
to
0784ed4
Compare
Batalex
force-pushed
the
feat/dpe-5591-status
branch
from
October 25, 2024 13:10
499a4cc
to
554d0ef
Compare
Batalex
commented
Oct 25, 2024
Batalex
force-pushed
the
feat/dpe-5591-status
branch
2 times, most recently
from
October 30, 2024 16:05
4f0ea3d
to
e4548db
Compare
deusebio
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! As already provided in the original PR
marcoppenheimer
approved these changes
Nov 12, 2024
Batalex
force-pushed
the
feat/dpe-5591-status
branch
from
November 12, 2024 15:44
d52312e
to
92f9495
Compare
Batalex
changed the title
[DPE-5591] Rework status handling
[DPE-5591] refactor: Rework status handling
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the list of changes in canonical/kafka-k8s-operator#141
Scenario's boilerplate setup takes longer to run than Harness'. I had to increase the unit test job timeout limit from 5 to 10 minutes.