ci, fix: change profile of mysql-k8s to testing, skip artefact collection on success #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mysql-k8s charm, used as kfp-db, has a profile configuration option that can be set to testing which sets the scope of deployment. This is recommended for testing environments with limited memory/disk.
This reverts commit 7d1429d.
orfeas-k
previously approved these changes
Nov 27, 2024
orfeas-k
dismissed
their stale review
Should we consider running collect debug artifacts only on failure() || cancelled()?
orfeas-k
previously approved these changes
Nov 27, 2024
The Github runners for the KFP CI are getting out of storage by the time the tests execution finishes, so there is no space left for saving logs. Skipping saving the debug artefacts on success will allow the workflows to run successfully.
DnPlas
changed the title
orfeas-k
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes to help alleviate the Github runners disk pressure.
The mysql-k8s charm, used as kfp-db, has a profile configuration option that can
be set to testing which sets the scope of deployment. This option configures the
sizes of buffers it uses to a small number (and it allocates those buffers upon startup);
otherwise, it uses the pod's resources as it should in production. If the pod has resource
limits, the buffers will be allocated relative to these resource limits; otherwise it will
allocate relative to host machine's resources.
This is recommended for testing environments.
The Github runners for the KFP CI are getting out of storage by the
time the tests execution finishes, so there is no space left for saving
logs. Skipping saving the debug artefacts on success will allow the workflows
to run successfully.