From a8973a6e323c6b362e7211d4be32f71534511688 Mon Sep 17 00:00:00 2001 From: Michal Hucko Date: Fri, 29 Nov 2024 12:59:19 +0100 Subject: [PATCH] Integrate `net-istio-webhook` rock (#248) * Integrate net-istio-webhook rock --- charms/knative-serving/src/charm.py | 2 +- charms/knative-serving/tests/unit/test_charm.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/charms/knative-serving/src/charm.py b/charms/knative-serving/src/charm.py index 09c0ad01..2660ac4e 100755 --- a/charms/knative-serving/src/charm.py +++ b/charms/knative-serving/src/charm.py @@ -28,7 +28,7 @@ CUSTOM_IMAGE_CONFIG_NAME = "custom_images" -DEFAULT_IMAGES = {} +DEFAULT_IMAGES = {"net-istio-webhook/webhook": "charmedkubeflow/net-istio-webhook:1.12.3-b455143"} class KnativeServingCharm(CharmBase): diff --git a/charms/knative-serving/tests/unit/test_charm.py b/charms/knative-serving/tests/unit/test_charm.py index 36afa8f2..350e64d7 100644 --- a/charms/knative-serving/tests/unit/test_charm.py +++ b/charms/knative-serving/tests/unit/test_charm.py @@ -204,11 +204,11 @@ def test_context_changes(harness): [ ( yaml.dump({"name1": "image1", "name2": "image2"}), - {"name1": "image1", "name2": "image2"}, + {**{"name1": "image1", "name2": "image2"}, **DEFAULT_IMAGES}, ), ( yaml.dump({}), - {}, + DEFAULT_IMAGES, ), ], )