Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: Disallow volume.security.shared on cephfs #14633

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+21 −7
Open

storage: Disallow volume.security.shared on cephfs #14633

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bdb9066
lxd/storage/drivers/cephfs: DIsallow set `volume.security.shared` on …
hamistao Dec 10, 2024
a53a777
test/suites: Test `security.shared` is not allowed for cephfs
hamistao Dec 10, 2024
d658d74
test/suites: Test `security.shared` is only allowed in block vols
hamistao Dec 10, 2024
fb08a39
test/suites: Fix ineffective tests
hamistao Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lxd/storage/drivers/driver_cephfs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,6 +437,8 @@ func (d *cephfs) Validate(config map[string]string) error {
// shortdesc: Whether the CephFS file system was empty on creation time
// scope: global
"volatile.pool.pristine": validate.IsAny,
// Override general 'security.shared' rule since only cephfs does not support block volumes.
"volume.security.shared": func(value string) error { return fmt.Errorf("") },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty error message looks odd?

}

return d.validatePool(config, rules, nil)
Expand Down