Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update libssh to 0.11.1 #3735

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Update libssh to 0.11.1 #3735

wants to merge 9 commits into from
+61 −27

Conversation

Sploder12
Copy link
Contributor

@Sploder12 Sploder12 commented Oct 16, 2024 •
edited
Loading

Sets the timeout to infinite since no messages for extended periods of time is expected behavior. Libssh updated to fix timeout being ignored.
Sets the pty mode explicitly to default since Libssh updated to inherit settings from stdin.

Fixes #3745

MULTI-1528

@codecov Codecov
Copy link

codecov bot commented Oct 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 32.00000% with 17 lines in your changes missing coverage. Please review.

Project coverage is 88.80%. Comparing base (bf3719d) to head (94890e4).
Report is 253 commits behind head on main.

Files with missing lines Patch % Lines
src/platform/platform_unix.cpp 0.00% 14 Missing ⚠️
src/sshfs_mount/sshfs_mount.cpp 75.00% 2 Missing ⚠️
src/platform/console/unix_console.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3735      +/-   ##
==========================================
- Coverage   88.93%   88.80%   -0.14%     
==========================================
  Files         254      255       +1     
  Lines       14299    14569     +270     
==========================================
+ Hits        12717    12938     +221     
- Misses       1582     1631      +49

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sploder12 Sploder12 marked this pull request as ready for review October 18, 2024 18:54
@ricab ricab requested a review from georgeliao October 21, 2024 09:06
ricab
ricab reviewed Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@ricab ricab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Trevor, thanks. I ask only for some unit tests for the new code. Other than that, +1 on my secondary review.

@Sploder12
Copy link
Contributor Author

Some reproduction steps for the issues.

Formatting:

  1. Run multipass launch -n <instance-name>
  2. Run multipass shell <instance-name>
  3. Observe incorrectly formatted shell and no ECHO

Mounts:

  1. Run multipass launch -n <instance-name>
  2. Run multipass mount <source> <target>
  3. Wait ~30 seconds after mount finishes mounting
  4. Run multipass shell <instance-name> (GUI doesn't have shell formatting issues)
  5. Attempt to navigate to the files in <target>
  6. Run ls or cd
  7. Observe shell hang

@sharder996 sharder996 added this to the 1.15.0 milestone Oct 30, 2024
@lars18th lars18th mentioned this pull request Nov 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricab ricab ricab left review comments

@georgeliao georgeliao Awaiting requested review from georgeliao

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.

SSHFS watchdog doesn't notice thread exit
3 participants
@Sploder12 @ricab @sharder996