fix: Add scipy to the UI jupyter-images list #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Libraries: OK
Libraries: Out of sync
and removed
Libraries: OK
labels
|
LGTM, but CI is acting up. |
|
Looks like Prometheus and Grafana were having issues (looks unrelated to the changes introduced here). Retriggering the failed run. |
|
So, I reran the tests which didn't help. I saw this error which seemed curious. It turns out, the error is caused by Prometheus, and more specifically this change introduced just yesterday, which assumes |
phoevos
force-pushed
the
fix-phoevos-ui-config-scipy
branch
from
ff07e98 to
cfc699d
Compare
Add `kubeflownotebookswg/jupyter-scipy:v1.7.0` to the list of jupyter-images exposed as a configurable option via the jupyter-ui charm. Adding it to the top of the list restores it as the default option. Signed-off-by: Phoevos Kalemkeris <[email protected]>
phoevos
force-pushed
the
fix-phoevos-ui-config-scipy
branch
from
cfc699d to
58a6868
Compare
github-actions
bot
added
Libraries: Out of sync
Libraries: OK
and removed
Libraries: OK
Libraries: Out of sync
labels
NohaIhab
approved these changes
Sep 4, 2023
NohaIhab
pushed a commit
that referenced
this pull request
Sep 26, 2023
Add `kubeflownotebookswg/jupyter-scipy:v1.7.0` to the list of jupyter-images exposed as a configurable option via the jupyter-ui charm. Adding it to the top of the list restores it as the default option. Signed-off-by: Phoevos Kalemkeris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
kubeflownotebookswg/jupyter-scipy:v1.7.0to the list of jupyter-images exposed as a configurable option via the jupyter-ui charm. Adding it to the top of the list restores it as the default option.Closes #290