Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport(fix): Comment out firing alert rule from #412 #414

Merged
merged 1 commit into from
Nov 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# Uncomment the alert below and modify the file's extension to be `.rule`
# once https://github.com/canonical/notebook-operators/issues/409 is fixed
# alert: JupyterControllerRuntimeReconciliationErrorsExceedThreshold
# expr: rate(controller_runtime_reconcile_errors_total[5m]) > 0
# for: 0m
# labels:
# severity: critical
# annotations:
# summary: Total number of reconciliation errors per controller
# description: >
# Total number of reconciliation errors per controller
# LABELS = {{ $labels }}

This file was deleted.

8 changes: 5 additions & 3 deletions charms/jupyter-controller/tests/unit/test_operator.py
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,11 @@ def test_prometheus_data_set(self, harness: Harness, mocker):
# there 2 alert rules in host_resources.rules
for rule in file_alert["groups"][0]["rules"]:
test_alerts.append(rule["alert"])
with open("src/prometheus_alert_rules/model_errors.rule") as f:
file_alert = yaml.safe_load(f.read())
test_alerts.append(file_alert["alert"])
# Uncomment once https://github.com/canonical/notebook-operators/issues/409
# is fixed.
# with open("src/prometheus_alert_rules/model_errors.rule") as f:
# file_alert = yaml.safe_load(f.read())
# test_alerts.append(file_alert["alert"])
with open("src/prometheus_alert_rules/KubeflowJupyterControllerServices.rules") as f:
file_alert = yaml.safe_load(f.read())
# there 2 alert rules in host_resources.rules
Expand Down
Loading