Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add loki rock #48

Merged
merged 4 commits into from
Aug 22, 2023
Merged

feat: add loki rock #48

merged 4 commits into from
Aug 22, 2023

Conversation

lucabello
Copy link
Collaborator

Ping the @canonical/rocks team.


Description

This PR adds the Loki ROCK to the oci-factory.

Related issues

#45

@lucabello lucabello marked this pull request as draft August 17, 2023 11:11
@cjdcordeiro cjdcordeiro mentioned this pull request Aug 17, 2023
13 tasks
@lucabello lucabello marked this pull request as ready for review August 17, 2023 12:40
@cjdcordeiro cjdcordeiro self-assigned this Aug 18, 2023
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again ;)

I have the same request as for other PRs of existing images - "making the 'Docker image vs ROCK' clear in the docs"

@lucabello lucabello requested a review from cjdcordeiro August 22, 2023 12:15
oci/loki/documentation.yaml Outdated Show resolved Hide resolved
oci/loki/documentation.yaml Outdated Show resolved Hide resolved
oci/loki/documentation.yaml Show resolved Hide resolved
@lucabello lucabello requested a review from cjdcordeiro August 22, 2023 14:12
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks;)

@cjdcordeiro cjdcordeiro merged commit 504e0a8 into canonical:main Aug 22, 2023
@cjdcordeiro
Copy link
Collaborator

@lucabello the Loki image failed the vulnerability tests and was not released -> https://github.com/canonical/oci-factory/actions/runs/5941580246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants