Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mimir rock #49

Merged
merged 2 commits into from
Aug 18, 2023
Merged

feat: add mimir rock #49

merged 2 commits into from
Aug 18, 2023

Conversation

lucabello
Copy link
Collaborator

Ping the @canonical/rocks team.


Description

This PR adds the Mimir ROCK to the oci-factory.

Related issues

#46

@lucabello lucabello marked this pull request as draft August 17, 2023 11:31
@lucabello lucabello marked this pull request as ready for review August 17, 2023 12:40
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's go!!! Thanks. LGTM

@cjdcordeiro cjdcordeiro self-assigned this Aug 18, 2023
@cjdcordeiro cjdcordeiro merged commit 825a084 into canonical:main Aug 18, 2023
@cjdcordeiro
Copy link
Collaborator

@lucabello this image didn't pass the vulnerability tests: https://github.com/canonical/oci-factory/actions/runs/5902799779

I suggest you try to fix these vulnerabilities, but if you can't, we can whitelist them (with proper justification), using this method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants