Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Octavia upload image script #212

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Octavia upload image script #212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion openstack/tools/upload_octavia_amphora_image.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,14 @@
#!/bin/bash -eu
juju run octavia-diskimage-retrofit/0 retrofit-image

source $(realpath $(dirname $0))/../novarc

IMAGE_ID=$(openstack image list --name jammy --format value --column ID)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this script previously took a release name via '--release foo' which is useful when running on a focal deploy. Defaulting to jammy won't work there so perhaps it should be put back, unless we can determine the release from something else?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, that's a good point. I'll work on this PR a bit more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is not necessary if we have #217 i.e. of an image exists in glance that corresponds to the version/release deployed (focal->ussuri, jammy->yoga etc).


if [[ -n ${IMAGE_ID} ]]; then
juju run octavia-diskimage-retrofit/0 retrofit-image source-image=${IMAGE_ID}
else
echo "Could not find a suitable image. Please upload a jammy image"
echo "to glance (e.g. by running the configure script) before"
echo "uploading an Octavia image."
exit 1
fi
Loading