default charmcraft_channel, TEST_VIP0X #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosaboy
reviewed
Sep 11, 2024
xtrusia
force-pushed
the
main
branch
2 times, most recently
from
db1bb2d to
6e3bf89
Compare
The charmcraft channel defaults to 1.5/stable [1], some charms omit it from osci.yaml [2] so we need to implement a default. [1] https://github.com/openstack-charmers/zosci-config/blob/master/roles/charm-build/defaults/main.yaml [2] https://github.com/openstack/charm-glance-simplestreams-sync/blob/stable/yoga/osci.yaml Adding TEST_VIP0x for some charms ( e.g charm-mysql-router ) [1] https://github.com/search?q=repo%3Aopenstack-charmers%2Fzaza-openstack-tests+TEST_VIP00&type=code
xtrusia
changed the title
xtrusia
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
charm func test runner: default charmcraft_channel
The charmcraft channel defaults to 1.5/stable [1], some charms omit
it from osci.yaml [2] so we need to implement a default.
[1] https://github.com/openstack-charmers/zosci-config/blob/master/roles/charm-build/defaults/main.yaml
[2] https://github.com/openstack/charm-glance-simplestreams-sync/blob/stable/yoga/osci.yaml
Adding TEST_VIP0x for some charms ( e.g charm-mysql-router )
[1] https://github.com/search?q=repo%3Aopenstack-charmers%2Fzaza-openstack-tests+TEST_VIP00&type=code