Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report results after charm func tests #230

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

dosaboy
Copy link
Member

@dosaboy dosaboy commented Sep 10, 2024

Report contains info about whether tests are voting or not and also the commit id the tests were run against.

@dosaboy dosaboy force-pushed the add-commit-to-func-tests branch 6 times, most recently from 51e9cc7 to 0f7a8a7 Compare September 10, 2024 13:29
@dosaboy dosaboy force-pushed the add-commit-to-func-tests branch 7 times, most recently from fb19fe2 to db770d1 Compare September 10, 2024 15:53
Copy link
Member

@pponnuvel pponnuvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Report contains info about whether tests are voting or not and
also the commit id the tests were run against.
@dosaboy dosaboy force-pushed the add-commit-to-func-tests branch from db770d1 to 368682c Compare September 10, 2024 17:28
Copy link
Collaborator

@nicolasbock nicolasbock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tox -re func-target -- $target || fail=true

if $fail; then
func_targets[$target]='fail'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a nice use of associative arrays 😄

@nicolasbock nicolasbock merged commit 4f85c0f into canonical:main Sep 10, 2024
3 checks passed
lathiat added a commit to lathiat/stsstack-bundles that referenced this pull request Sep 11, 2024
The list of test targets was always "target" instead of the actual list
of targets due to an accidentally ommited $-sign in canonical#230
slapcat pushed a commit to slapcat/stsstack-bundles that referenced this pull request Nov 7, 2024
The list of test targets was always "target" instead of the actual list
of targets due to an accidentally ommited $-sign in canonical#230
slapcat pushed a commit to slapcat/stsstack-bundles that referenced this pull request Nov 10, 2024
The list of test targets was always "target" instead of the actual list
of targets due to an accidentally ommited $-sign in canonical#230
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants