-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report results after charm func tests #230
Conversation
51e9cc7
to
0f7a8a7
Compare
fb19fe2
to
db770d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Report contains info about whether tests are voting or not and also the commit id the tests were run against.
db770d1
to
368682c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tox -re func-target -- $target || fail=true | ||
|
||
if $fail; then | ||
func_targets[$target]='fail' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a nice use of associative arrays 😄
The list of test targets was always "target" instead of the actual list of targets due to an accidentally ommited $-sign in canonical#230
The list of test targets was always "target" instead of the actual list of targets due to an accidentally ommited $-sign in canonical#230
The list of test targets was always "target" instead of the actual list of targets due to an accidentally ommited $-sign in canonical#230
Report contains info about whether tests are voting or not and also the commit id the tests were run against.