-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow searching for rooms in the ubuntu.com instance from federation #126
Comments
The allow_public_rooms_over_federation is true by default and it was added as configuration in case we decided to change it. I'm concerned that enabling it could be a potential security risk: Note: this option only relates to public room list/search. If a user know the name of the room, they can join it by federation as expected. @merkata @gregory-schiano thoughts? |
My understanding of the feature request is to have them enabled for federated servers, but not for unauth |
Well, in my opinion to avoid this problem we should just have different homeservers for As currently having |
Can we get an update on this issue? This makes it difficult for external users to actually join our rooms. Some observations from my side:
Adding the server search list from
I think it's the other way around: the blogpost states that relying on these two configuration values for security is bad. Even with both config options set to If some rooms should not be joined by the public, then those rooms need to be private. This is already the case: people using the server correctly anticipate that |
I had to explicitly set this on my homeserver to make public room discovery work:
It should be the default setting but did not work until i set the values. |
Ok this is fixed now, at least I've been able to browse the rooms from both element and nheko |
@gregory-schiano #126 (comment) indicates this is fixed now, can you confirm and close the ticket, please? |
Fixed with #119 |
Your use case
What would you like to do?
I would like to grant external users from federated servers to be able to add ubuntu.com to the server search list.
This is currently not allowed, as shown in the attached screenshot.
Why would you like to do it?
I would like to enable this feature so that users that are not logging in directly on our instance can still search rooms on the ubuntu.com instance. This will make our instance more accessible to people that do not have direct links to our rooms and spaces.
How would you like to achieve it?
This article on Matrix.org goes through a couple of relevant options in the homeserver.yaml file: https://matrix.org/blog/2019/11/09/avoiding-unwelcome-visitors-on-private-matrix-servers/
Have you considered any alternatives?
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: