Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synapse charm review PR: Fix Python code #52

Closed
amandahla opened this issue Sep 27, 2023 · 39 comments
Closed

Synapse charm review PR: Fix Python code #52

amandahla opened this issue Sep 27, 2023 · 39 comments
Assignees
@amandahla

Comments

@amandahla
Copy link
Collaborator

amandahla commented Sep 27, 2023 •
edited
Loading

This issue should address comments regarding Python code like:

  • Variables names/location
  • Libraries to be used
  • Rephrase comments
  • Docstrings
  • Lint issues

Architectural changes (Observer/Service/Modules) should be addressed in a different issue.
@amandahla amandahla mentioned this issue Sep 27, 2023
Closed
@amandahla
Copy link
Collaborator Author

#43 (comment)

@amandahla
Copy link
Collaborator Author

#43 (comment)

@amandahla
Copy link
Collaborator Author

#43 (comment)

@amandahla
Copy link
Collaborator Author

#43 (comment)

@amandahla
Copy link
Collaborator Author

#43 (comment)

@amandahla
Copy link
Collaborator Author

#43 (comment)

@amandahla
Copy link
Collaborator Author

#43 (comment)

@amandahla
Copy link
Collaborator Author

#43 (comment)

@amandahla
Copy link
Collaborator Author

#43 (comment)

@amandahla
Copy link
Collaborator Author

#43 (comment)

@amandahla
Copy link
Collaborator Author

#43 (comment)

@amandahla
Copy link
Collaborator Author

#43 (comment)

@amandahla
Copy link
Collaborator Author

#43 (comment)

@amandahla
Copy link
Collaborator Author

#43 (comment)

@amandahla
Copy link
Collaborator Author

#43 (comment)

@amandahla
Copy link
Collaborator Author

#43 (comment)

@amandahla
Copy link
Collaborator Author

#43 (comment)

@amandahla
Copy link
Collaborator Author

#43 (comment)

@amandahla
Copy link
Collaborator Author

#43 (comment)

@amandahla
Copy link
Collaborator Author

#43 (comment)

@amandahla
Copy link
Collaborator Author

#43 (comment)

@amandahla
Copy link
Collaborator Author

#43 (comment)

@amandahla
Copy link
Collaborator Author

#43 (comment)

@amandahla
Copy link
Collaborator Author

#43 (comment)

@amandahla
Copy link
Collaborator Author

#43 (comment)

@amandahla
Copy link
Collaborator Author

#43 (comment)

@amandahla
Copy link
Collaborator Author

#43 (comment)

1 similar comment
@amandahla
Copy link
Collaborator Author

#43 (comment)

@amandahla amandahla reopened this Sep 27, 2023
@amandahla
Copy link
Collaborator Author

#43 (comment)

@amandahla
Copy link
Collaborator Author

#43 (comment)

@amandahla
Copy link
Collaborator Author

#43 (comment)

@amandahla
Copy link
Collaborator Author

#43 (comment)

@amandahla
Copy link
Collaborator Author

#43 (comment)

@amandahla
Copy link
Collaborator Author

#43 (comment)

@amandahla
Copy link
Collaborator Author

#43 (comment)

@amandahla
Copy link
Collaborator Author

#43 (comment)

@amandahla
Copy link
Collaborator Author

#77 (comment)

@cbartz
Copy link
Contributor

cbartz commented Nov 12, 2024

@amandahla What is the status here, please?

@amandahla
Copy link
Collaborator Author

The charm has changed a lot since this was opened. Closing as it’s no longer relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amandahla amandahla

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cbartz @amandahla