fix: Pin Prometheus and Grafana revisions #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a temporary patch until we migrate to Juju 3.1: * Pin Prometheus revision when deploying from `latest` to avoid fetching recent patches of the charm which assume `juju >= 3.0.3`. Revision 137 was the last one seen working properly in our CI integration tests. * Pin Grafana revision when deploying from `latest` to avoid fetching recent patches of the charm which fail to install on Juju 2.9. Revision 89 was the last one working properly in our CI integration tests. Signed-off-by: Phoevos Kalemkeris <[email protected]>
i-chvets
previously approved these changes
Sep 2, 2023
There was a problem hiding this comment.
This PR contains changes to ensure that integration tests are passing in CI.
These changes were discussed outside of this PR as well.
The fix is to temporary pin Prometheus and Grafana versions.
Approved. Pending CI.
UPDATE: Integration tests are not passing in CI.
|
Retriggered the tests and now the CI is passing, so probably transient (could be a timeout causing the connection to break). |
i-chvets
approved these changes
Sep 2, 2023
DnPlas
pushed a commit
that referenced
this pull request
Sep 11, 2023
This is a temporary patch until we migrate to Juju 3.1: * Pin Prometheus revision when deploying from `latest` to avoid fetching recent patches of the charm which assume `juju >= 3.0.3`. Revision 137 was the last one seen working properly in our CI integration tests. * Pin Grafana revision when deploying from `latest` to avoid fetching recent patches of the charm which fail to install on Juju 2.9. Revision 89 was the last one working properly in our CI integration tests. Signed-off-by: Phoevos Kalemkeris <[email protected]>
DnPlas
added a commit
that referenced
this pull request
Sep 11, 2023
fix: Pin Prometheus and Grafana revisions (#128)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary patch until we migrate to Juju 3.1:
latestto avoid fetching recent patches of the charm which assumejuju >= 3.0.3. Revision 137 was the last one seen working properly in our CI integration tests.latestto avoid fetching recent patches of the charm that fail to install on Juju 2.9. Revision 89 was the last one working properly in our CI integration tests.Refs canonical/bundle-kubeflow#688
Refs canonical/bundle-kubeflow#690