Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(android): make querying contacts consistent with ios #97

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+30 −6
Open

refactor(android): make querying contacts consistent with ios #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 30 additions & 6 deletions android/src/main/java/getcapacitor/community/contacts/Contacts.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,16 +134,42 @@ public ContactPayload getContact(@NonNull String contactId, GetContactsProjectio
public HashMap<String, ContactPayload> getContacts(GetContactsProjectionInput projectionInput) {
String[] projection = projectionInput.getProjection();

// String[] selectionArgs = projectionInput.getSelectionArgs();
String[] selectionArgs = projectionInput.getSelectionArgs();

// String selection = GetContactsProjectionInput.getSelection(selectionArgs);
String selection = GetContactsProjectionInput.getSelection(selectionArgs);

HashMap<String, ContactPayload> contacts = new HashMap<>();

ContentResolver cr = this.mActivity.getContentResolver();
// Cursor cursor = contentResolver.query(ContactsContract.Data.CONTENT_URI, projection, selectionArgs.length > 0 ? selection : null, selectionArgs.length > 0 ? selectionArgs : null, null);
Cursor cursor = cr.query(ContactsContract.Data.CONTENT_URI, projection, null, null, null);

if (selectionArgs.length > 0) {
// At least some fields (besides the contactId) are being queried.
// First we'll retrieve all contacts having at least one of these fields (this is called the selection).
// Also we only retrieve the requested fields (and the contactId field) (this is called the projection).
Cursor cursor = cr.query(ContactsContract.Data.CONTENT_URI, projection, selection, selectionArgs, null);
moveOverCursor(contacts, cursor);

// Now that we have all the contacts matching the selection and projection,
// we'll also want to retrieve the remaining contacts.
// Since there is no way really to retrieve "the remaining" contacts efficiently,
// we'll just retrieve them all.
// Also since these contacts apparently do not have any matching fields,
// we only need to retrieve the contactId field.
String[] contactIdOnlyProjection = new String[] { ContactsContract.Data._ID, ContactsContract.Data.CONTACT_ID };
Cursor cursorAllContacts = cr.query(ContactsContract.Data.CONTENT_URI, contactIdOnlyProjection, null, null, null);
moveOverCursor(contacts, cursorAllContacts);
} else {
// No specific fields are being queried.
// This can happen if the projection is empty.
// Probably the user only wants a list of all contacts and their contactId returned.
Cursor cursor = cr.query(ContactsContract.Data.CONTENT_URI, projection, null, null, null);
moveOverCursor(contacts, cursor);
}

return contacts;
}

private void moveOverCursor(HashMap<String, ContactPayload> contacts, Cursor cursor) {
if (cursor != null && cursor.getCount() > 0) {
while (cursor.moveToNext()) {
// String _id = cursor.getString(cursor.getColumnIndex(ContactsContract.Contacts._ID));
Expand All @@ -167,8 +193,6 @@ public HashMap<String, ContactPayload> getContacts(GetContactsProjectionInput pr
if (cursor != null) {
cursor.close();
}

return contacts;
}

public String createContact(CreateContactInput contactInput) {
Expand Down