Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(barcode-scanning): missing privacy manifest #178

Closed
3 of 7 tasks
akships opened this issue Aug 24, 2024 · 8 comments · Fixed by #179
Closed
3 of 7 tasks

bug(barcode-scanning): missing privacy manifest #178

akships opened this issue Aug 24, 2024 · 8 comments · Fixed by #179
Milestone

Comments

@akships
Copy link

akships commented Aug 24, 2024

Plugin(s)

  • Barcode Scanning
  • Face Detection
  • Face Mesh Detection
  • Selfie Segmentation
  • Translation

Current problem

When I push my app to apple there is always this warning about privacy

privacy-apple

Preferred solution

I think this is due to dependency to MLKIT (which is dependent to an old version of GoogleToolboxForMac) version which is 5.0.0 currently and should be at least 6.0.0 or even 7.0.0.
On those latest versions the privacy issue is fixed.

Is it possible to update podspec to fix this or another solution in mind ?

Alternative options

No response

Additional context

Using current latest version of package 6.1.0

Before submitting

@robingenz
Copy link
Member

According to the changelog, the latest version for GoogleMLKit/BarcodeScanning is 5.0.0. This version is used by the plugin.

@Mercury-Ong
Copy link

Mercury-Ong commented Aug 25, 2024

Hi! I updated the GoogleMLKit/BarcodeScanning to 6.0.0 manually and ran pod update.
These packages were updated, and everything seems to be working fine. (for now)

Installing CapacitorMlkitBarcodeScanning 6.1.0
Installing GoogleMLKit 6.0.0 (was 5.0.0)
Installing GoogleToolboxForMac 4.2.1 (was 2.3.2) 
Installing MLKitBarcodeScanning 5.0.0 (was 4.0.0)
Installing MLKitCommon 11.0.0 (was 10.0.0)
Installing MLKitVision 7.0.0 (was 6.0.0)

The privacy policy was added on version 4.2.0 for GoogleToolboxForMac.

@robingenz
Copy link
Member

robingenz commented Aug 28, 2024

I have created a PR to update the pods: #179. Unfortunately, it contains breaking changes, so I can't merge the PR yet. You can use the pre-release in the meantime:

npm i https://pkg.pr.new/capawesome-team/capacitor-mlkit/@capacitor-mlkit/barcode-scanning@327eae6

@robingenz robingenz added breaking change Breaking change and removed needs: triage labels Aug 28, 2024
@robingenz robingenz added this to the v7.0.0 milestone Aug 28, 2024
@robingenz robingenz changed the title feat: update dependecy to mlkit to solve privacy issue with apple feat: update dependecies to solve privacy issue with Apple Oct 3, 2024
@robingenz robingenz pinned this issue Oct 3, 2024
@robingenz robingenz changed the title feat: update dependecies to solve privacy issue with Apple bug: missing privacy manifest Oct 3, 2024
@robingenz robingenz added bug/fix Something isn't working and removed feature Feature labels Oct 3, 2024
@robingenz robingenz changed the title bug: missing privacy manifest bug(barcode-scanning): missing privacy manifest Oct 3, 2024
@robingenz
Copy link
Member

Closed by #179. Please install the latest version using the next tag:

npm install @capacitor-mlkit/barcode-scanning@next

@geckozr
Copy link

geckozr commented Nov 12, 2024

While updating to ^7.0.0-next.1, I'm receiving this error:

[capacitor] ✖ update ios - failed!
[capacitor] [error] Analyzing dependencies
[capacitor]         [!] CocoaPods could not find compatible versions for pod "GoogleMLKit/BarcodeScanning":
[capacitor]         In Podfile:
[capacitor]         CapacitorMlkitBarcodeScanning (from `../../node_modules/@capacitor-mlkit/barcode-scanning`) was resolved to 7.0.0-next.1, which depends on
[capacitor]         GoogleMLKit/BarcodeScanning (= 7.0.0)
[capacitor]         
[capacitor]         Specs satisfying the `GoogleMLKit/BarcodeScanning (= 7.0.0)` dependency were found, but they required a higher minimum deployment target.
[capacitor]       

To correctly build the application, I had to increase the iOS platform version in my Podfile to: platform :ios, '15.5'

Is this supposed to be correct?

@robingenz
Copy link
Member

robingenz commented Nov 12, 2024

@geckozr Yes, see BREAKING.md. That's the reason why we can't publish a new latest version before the next major release.

@hoangqwe159
Copy link

@robingenz can you manage to merge the fix for GoogleMLKit/BarcodeScanning in version 6, please? My project cannot increase the the IOS platform version to 15.5; I believe it is the same for many others.

@robingenz
Copy link
Member

@hoangqwe159 That's the problem. We have to increase the minimum deployment target to be able to merge it. This is a requirement from the ML Kit Barcode Scanning SDK.

phoebus-84 added a commit to ForkbombEu/wallet that referenced this issue Dec 2, 2024
- use mlkit/7.0 @next.2 see capawesome-team/capacitor-mlkit#178
- because of this bumb ios mimum target from 13.0 to 15.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants