-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(barcode-scanning): add web support #52
base: main
Are you sure you want to change the base?
Conversation
Hi, please, is there any update of this? I am using this plugin on Android and I want to use it on mobile web browser (mainly iOS). Is it possible? Can I help with continue of this? |
Hello! Merging such a feature like this would be helpful :) @robingenz |
Any updates to this? |
Hi, I spent some time to try this code. Now, it is not up to date and I had to change some things to update it to latest master. After that, I had lot of problems with camera on my computer. The code The last thing, I wanted to use this code for support my app on iOS, because I cannot pay for Applle developper account, but this is not supported in Safari. |
Any update on this please @robingenz |
Any updates already on this issue? @robingenz |
No, there are currently no updates. |
Testing it with the last commits from the main (checked out this PR and merged main) and it works on the web, but iOS (and possibly Android, not tested) was broken - it cannot serialize
But I think this is bug - native plugin should ignore videoElement option. |
@robingenz Why you choose the ways with passing custom videoElement in the options? Other similar plugin creates video element in the plugin, so for developer the web plugin works similarly to native plugins - video will appear under the DOM tree on all platforms, so there is less surface for bugs. |
Hi, I’ve just rewrote it to the updated API and changed web plugin to automatically create video element, so options are consistent to the native plugins. My PR: #211 |
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run changeset
).Close #20