-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add data accuracy tests #17
Conversation
…ifacts into add-data-accuracy-tests
Updated with command line support for specifying test/compare nodes along with the description. Ready for review I think |
… for http, and update schema (pool ticker is nullable)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added few cosmetic changes, alongwith example command to use pytest, only thing I'd consider is potentially dropping tip from data tests (since that could go off for seconds difference between instances - on either side), but other than that looks good to merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't touched python much and as such makes it a bit difficult to properly assess code. But I trust in yours and priyanks ability on this.
Description
First-take of detailed tests to be run against contributing instances from monitoring, or locally during development/instance verification.
To consider:
Endpoints Tested
Network
Epoch
Block
Transactions
Address
Account
Asset
Pool
Script
Where should the reviewer start?
Tests can be executed locally by setting up the test env with
setup-tests.py
and then runningpytest
fromtests
directory. This runs with default params specified intests/conftest.py
. You can pass in the parameters via the command line:pytest --local-url https://eden-guildnet.koios.rest:8453/api/v0 --compare-url https://guild.koios.rest/api/v0 --api-schema-file ../specs/results/koiosapi-guild.yaml
To specify specific test files:
pytest -s test_totals_endpoint.py
Motivation and context
We need more detailed testing to continually verify both our API schema with calls that are not covered by examples in the API spec (schema changes in this PR are the result of inconsistencies found during testing), and that contributing instances are serving healthy data.
Which issue it fixes?
Closes #9
How has this been tested?
Guild:
Testnet:
Mainnet: