Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] AdaHandle support #56

Open
matiwinnetou opened this issue Jun 25, 2023 · 3 comments
Open

[FEATURE] AdaHandle support #56

matiwinnetou opened this issue Jun 25, 2023 · 3 comments
Labels
enhancement New feature or request feature question Further information is requested

Comments

@matiwinnetou
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Many Cardano Connect with Wallet integrations upon connection let a user choose ada handle. Once ada handle is chosen, the wallet connector doesn't display a stake address but ada handle, e.g. $matiwinnetou

Describe the solution you'd like
Add additional property to the react component so it is possible to pick adahandle and once user picks adahandle it becomes sticky.

Describe alternatives you've considered
Basically one can extend cardano-connect-with-wallet, fork it and provide this functionality without being in the common component.

@fabianbormann
Copy link
Contributor

fabianbormann commented Jul 12, 2023

Hi @matiwinnetou, if I'm right, we would need to query all assets of the stake address (from e.g. koios) and search for the handles and then use it as the default button title (if connected). https://docs.adahandle.com/quick-start

A feasible and lightweight solution would be to add a connectedLabel prop (in contrast to that prop) so that a developer would be able to fetch the adahandle via koios/blockfrost, show a selection dialog and then he/she would be able to do:

<ConnectWalletButton connectedLabel={adahandle} />

...

A more complex alternative would be to introduce a prop useAdaHandle and implement the fetch- and display-logic inside the component. I don't know if this would bring to much load to koios or if we would need to introduce a fetchAssetsUrl, so that devs could use their own blockfrost api key inside a backend service 🤔 .. what do you think about it?

@fabianbormann fabianbormann added enhancement New feature or request question Further information is requested feature labels Aug 7, 2023
@fabianbormann
Copy link
Contributor

As discussed with @satran004 we will now work on a service to resolve adahandles using yaci-store and bring that open source and 24/7 up in the cf environment allowing also community projects to use it 😊 .. I will link the project and it's status here once it's released in v0.0.1 😉

@fabianbormann
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants