Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About ch 1 ex 4 solution #3

Open
viatsko opened this issue Sep 25, 2016 · 0 comments
Open

About ch 1 ex 4 solution #3

viatsko opened this issue Sep 25, 2016 · 0 comments

Comments

@viatsko
Copy link

viatsko commented Sep 25, 2016

Hi,

Looking at this solution:
https://github.com/careercup/CtCI-6th-Edition-JavaScript-ES2015/blob/master/src/chapter1/ch1-q4.js

We are missing the case when string is given with upper case characters (which is true for the original assignment - the string given is "Tact Coa"). I'd suggest to use toLowerCase() and update tests, what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant