Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: ready sql database file and async API #4

Open
ghost opened this issue Oct 17, 2020 · 3 comments
Open

Suggestion: ready sql database file and async API #4

ghost opened this issue Oct 17, 2020 · 3 comments

Comments

@ghost
Copy link

ghost commented Oct 17, 2020

As in title.

Database is kind of huge, so it'll be nice to have it in sql database (instead in RAM) and use same API but with async functions.
It could be, like you pass info of your database where u've uploaded sql file - as options to constructor. Then you can use all the same functions with async suffix.

@carlospolop
Copy link
Owner

Hi @Kamil93,

Sorry, I don't understand what you are suggesting, Could you explain it better?

@ghost
Copy link
Author

ghost commented Oct 17, 2020

All the informations about IPs are huge and this library keeps these informations in RAM memory. It would be very usefull to keep it in database like mysql. Also keeping same API but with async functionality.

@carlospolop
Copy link
Owner

Oh yeah, I completely agree.
Unfortunately I won't have for this in the near future.
Please, feel free to implement this change and submit a push request if you want and I will accept it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant