Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-design casbin model conf to achieve Turing-complete #118

Open
hsluoyz opened this issue Apr 17, 2020 · 7 comments
Open

re-design casbin model conf to achieve Turing-complete #118

hsluoyz opened this issue Apr 17, 2020 · 7 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@hsluoyz
Copy link
Member

hsluoyz commented Apr 17, 2020

Apache Teaclave (https://github.com/apache/incubator-teaclave) is an Apache incubator project focusing on SGX. They implement a similar modeling language as Casbin but seems to be more powerful (Turing-complete). See: apache/incubator-teaclave#265

acs: https://github.com/apache/incubator-teaclave/tree/6d53e8b4fe841598e0472a9abd27776c91e90469/mesatee_services/acs

Can we make our Casbin language Turing complete too?

@hsluoyz hsluoyz self-assigned this Apr 17, 2020
@hsluoyz hsluoyz added enhancement New feature or request help wanted Extra attention is needed labels Apr 17, 2020
@GopherJ GopherJ pinned this issue May 9, 2020
@GopherJ GopherJ added this to the v1.0.0 milestone May 9, 2020
@GopherJ GopherJ changed the title Make Casbin language Turing-complete to be used by Apache Teaclave re-design casbin model conf to make it Turing-complete May 10, 2020
@GopherJ GopherJ changed the title re-design casbin model conf to make it Turing-complete re-design casbin model conf to achieve Turing-complete May 10, 2020
@GopherJ
Copy link
Member

GopherJ commented May 11, 2020

See also: casbin/casbin#432

@schungx
Copy link
Contributor

schungx commented May 27, 2020

What you need is a rules engine in this case, and not a language per se (although the rules may be expressed in a language syntax). You probably also need to trade off the complexity of maintaining a rules engine vs. keeping to the most common usages but be simple.

The main difference between a rules engine and a language interpreter is that, in a rules engine, you have to topological sort the rules (basically a dependency graph) according to execution order (layers) and to detect cycles/loops, because the rules will not be run in the order scripted.

I have written such rules engine years ago on top of a expression syntax. Maybe if I have some free time, I'll whip out a simple module based on Rhai for you to test out.

@schungx
Copy link
Contributor

schungx commented May 27, 2020

If someone would like to design, based on casbin needs, what the rules will look like (hopefully they're all similar to Rhai syntax), then I can just code according to that design.

@GopherJ
Copy link
Member

GopherJ commented May 27, 2020

@schungx Yeah it can be interested in testing your rule engine module, I have used some rule engines but they are quite limited and lack of powerful expressions.

If someone would like to design, based on casbin needs, what the rules will look like (hopefully they're all similar to Rhai syntax), then I can just code according to that design.

For this moment, I think we pretty need some methods on array like:

  • any
  • all
  • reduce

JS syntax is fine I think

@schungx
Copy link
Contributor

schungx commented May 27, 2020

So if we stick to normal function calls syntax with no wierd symbols, plus assignment statements to define rules, that should be enough?

Normally rules are something like:

Rule_1 -> Conditon1:all, Conditon2:any | Condition3

This will be expressed as

rule_1 = all(condition1) && any(condition2) || condition3;

In fact, if you order the rules in the correct execution order, and put let in front of the rule names, then you really get a Rhai scriptlet. If I put in a feature to omit the let keyword (i.e. assignment to a non-existing variable creates it), then it'll be a valid script by itself.

Actually you'd want to decide whether you really want a true rules engine, or whether you want your rules to be scriptable -- meaning that your user can actually write a mini-program for the matching, returning a value, with full language features such as loops, if-else etc.

@schungx
Copy link
Contributor

schungx commented May 28, 2020

From what I can tell, Teaclave has a solver engine (or inference engine), which is one step up from a rules engine. A solver engine does back-tracking to try different combinations to find a solution.

The problem is that running a full-blown solver for each enforce operation is gotta be very slow, unless a lot of optimizations are done. However, logic is obviously much simpler to express for a solver than to actually write a program to search for a solution. So essentially, you're trading off power/ease of expression vs. ease of implementation.

Another problem with expressing logic rules is that it is hard to do calculations (at least not without going through a lot of hoops). Depending on the engine, simple things like p.sub.age > 16 is going to be clumsy to formulate without first defining what it means by greater-than.

If you really want a solver, maybe something like https://github.com/rust-lang/chalk is a good choice, since it is the future engine for Rust's trait solver.

@GopherJ GopherJ modified the milestones: v1.0.0, v2.0.0 Jun 1, 2020
@hsluoyz hsluoyz unpinned this issue Dec 21, 2020
@BatmanAoD
Copy link

What would be the benefit of having a Turing-complete model language? I feel like that would be a source of performance and correctness footguns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants