add_policies only updates policies, but not policy_map

[derberni]

If you compare the two functions for adding a single, or multiple policies in model/policy.py, the add_policies method only appends the new rules, but does not update the policy_map if a priority is given for the rule.

[casbin-bot]

@techoner @Nekotoxin

[hsluoyz]

@derberni try other languages like Go, Java, Node Casbin

[derberni]

I checked the Go source code for AddPolicies, and it works correctly. Basically the Go AddPolicies calls AddPolicy for each policy. The python code for add_policies does not use add_policy internally, but directly appends the policy list to the model.

[hsluoyz]

Task: need to port the policy_map handling from Go to Python. See the below links.

Note: consider not only add_policies but also other similar functions like: update_policies, remove_policies, etc. in the same source code file

Go:

https://github.com/casbin/casbin/blob/c55ed50772950c9b6eb80460fed5b889e0df87fd/model/policy.go#L259-L279

Python:

pycasbin/casbin/model/policy.py

Lines 149 to 159 in 7b64b85

	def add_policies(self, sec, ptype, rules):
	"""adds policy rules to the model."""
	for rule in rules:
	if self.has_policy(sec, ptype, rule):
	return False
	for rule in rules:
	self[sec][ptype].policy.append(rule)
	return True