Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] the version should be casdoor-app's version, instead of Expo version #38

Closed
hsluoyz opened this issue Dec 12, 2024 · 0 comments · Fixed by #40
Closed

[bug] the version should be casdoor-app's version, instead of Expo version #38

hsluoyz opened this issue Dec 12, 2024 · 0 comments · Fixed by #40
Assignees
@hsluoyz
Labels
bug Something isn't working

Comments

@hsluoyz
Copy link
Member

hsluoyz commented Dec 12, 2024

I used Expo app to scan the QR code in PR: #37 . casdoor-app's version shows it's 2.32.11

image

But it's actually Expo Go's version, not casdoor-app's version:

image

It's better to show the real related versions like 1.14.0, 1.15.0 or the commit hash: 136af5d

image
@hsluoyz hsluoyz self-assigned this Dec 12, 2024
@hsluoyz hsluoyz added the bug Something isn't working label Dec 12, 2024
@IZUMI-Zu IZUMI-Zu mentioned this issue Dec 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hsluoyz hsluoyz

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: display runtime version for Expo Go IZUMI-Zu/casdoor-app
1 participant
@hsluoyz