feat: Add working-directory attribute #2438
Conversation
src/recipe.rs
Outdated
| } | ||
|
|
||
| let working_dir = self |
There was a problem hiding this comment.
I think this is better implemented as a for loop:
let working_directory = context.working_directory();
for attribute in self.attributes {
if let Attribute::WorkingDirectory(dir) = attribute {
return Some(working_directory.join(dir.cooked);
}
}
Some(working_directory)Also note the use of cooked, which is the contents of the string literal after processing escape sequences.
There was a problem hiding this comment.
I think this is better implemented as a for loop
Yup, the suggested for loop reads better and is more concise. Just curious, is there any other reason you suggested this refactor?
Also note the use of cooked, which is the contents of the string literal after processing escape sequences.
Good to know - thanks for the info!
tests/working_directory.rs
Outdated
| echo "$(basename "$PWD")" | ||
|
|
||
| [working-directory('bar')] | ||
| [working-directory('baz')] |
There was a problem hiding this comment.
Duplicate working directory attributes should be an error.
There was a problem hiding this comment.
Sorry for taking so long to get this in! I made [no-cd] and [working-directory] conflict, so you can't have them both on a recipe. I also added an expect_file function to the test runner, which allowed the tests to be simplified, since you can touch a file and check that a file in the expected directory was created.
|
Thanks @casey! Looking forward to using this in my projects 😍 |
Closes #2082