Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snapshot tests for iOS 15 and audit results #67

Open
Sherlouk opened this issue Jun 26, 2021 · 5 comments
Open

Add snapshot tests for iOS 15 and audit results #67

Sherlouk opened this issue Jun 26, 2021 · 5 comments
Assignees
Labels
good first issue Good for newcomers Switch Control parity Mismatch between output of framework and actual Switch Control behavior VoiceOver parity Mismatch between output of framework and actual VoiceOver behavior

Comments

@Sherlouk
Copy link
Contributor

This'll include changes to the GitHub Actions workflow. We'll want to double check that everything still works.

We may also want to explore the new DocC feature set to ensure we have good coverage across the board, and offer up some basic guides on how to use the package.

@NickEntin
Copy link
Collaborator

Have you tested it out yet to see if anything breaks?

Xcode 13 is only available on the macOS 11 image for GitHub Actions, which is currently in private preview and I'm not sure if our org has access yet. We can definitely try it though.

We'll want to maintain Xcode 12 support for a while, so we should add an Xcode 13 build in additional to the existing jobs.

@NickEntin
Copy link
Collaborator

I haven't looked very deep into DocC yet, but agreed it's definitely worth exploring.

@NickEntin
Copy link
Collaborator

macOS 11 is now generally available, so we're unblocked on the CI side to add an iOS 15 / Xcode 13 build at this point.

@Sherlouk Did you get a chance to test it out with Xcode 13 and see if everything works alright?

@Sherlouk
Copy link
Contributor Author

Sherlouk commented Sep 8, 2021

I have not yet taken a look at Xcode 13 and this library, I'm a bit behind on my own projects currently.

@NickEntin NickEntin changed the title iOS 15 / Xcode 13 Update Add snapshot tests for iOS 15 and audit results Jan 20, 2023
@NickEntin
Copy link
Collaborator

Now that CI is unblocked, we should add the iOS 15 build. We need to:

  • Add iOS 15 to our build script and record new reference images
  • Update the CI config to include an iOS 15 build
  • Audit the reference images against VoiceOver on a device running iOS 15 and file issues for any changes/regressions where the behavior doesn't match

@NickEntin NickEntin added VoiceOver parity Mismatch between output of framework and actual VoiceOver behavior Switch Control parity Mismatch between output of framework and actual Switch Control behavior labels Aug 3, 2023
@NickEntin NickEntin self-assigned this Oct 13, 2023
@NickEntin NickEntin added the good first issue Good for newcomers label Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Switch Control parity Mismatch between output of framework and actual Switch Control behavior VoiceOver parity Mismatch between output of framework and actual VoiceOver behavior
Projects
None yet
Development

No branches or pull requests

2 participants