Added Identifier to inverted snapshot tests #55
Conversation
|
@NickEntin here is a draft PR of my fix. The reason for this being a draft is the local inversion of the entire screen instead of just the colours |
|
|
||
| @testable import AccessibilitySnapshotDemo | ||
|
|
||
| final class IdentifierTests: SnapshotTestCase { |
There was a problem hiding this comment.
Instead of a new test class, I think we should add this test to InvertColorsTests, i.e. testInvertColorsWithIdentifier().
|
@joshmsamuels I filed #56 to track fixing the flipped image issue |
joshmsamuels
force-pushed
the
jsamuels/inverted_add_identifier
branch
from
45e29f4 to
7afa51c
Compare
|
Thanks! @NickEntin sorry for another ping but do you have any idea why some of the tests are failing? All the snapshots appear to be the same and all the tests pass locally. It seems really odd that the iOS 12 tests are passing here but 13 & 14 are failing |
@joshmsamuels I'm having trouble reproducing the issue locally. See my comment in #56. Can you test locally and see which path it's taking? |
closes #51