Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readability - action findings of accessibility report #15

Open
JasleenKJolly opened this issue Oct 9, 2020 · 3 comments
Open

Readability - action findings of accessibility report #15

JasleenKJolly opened this issue Oct 9, 2020 · 3 comments
Labels
good first issue Good for newcomers

Comments

@JasleenKJolly
Copy link

The text is clear and readable. When I checked with my app which simulates colour vision defects the hyperlinks don't stand out. I wonder whether it would be possible to make them more obvious, perhaps with a colour background or underline and a key to show this means hyperlink?

The EDIs website has a great function where the background birghtness can be altered by the individual so set contrast and glare levels at a comfortable point. I am not sure how this was implemented but if at the hackday something like this could be implemented I think that would be wonderful.

How compatible is github with screen readers used by people with visual impairment and processing difficulties? I could not find any information on this.

Thanks to you and the team on all your wonderful work on this.

@cassgvp
Copy link
Owner

cassgvp commented Oct 12, 2020

Hi @JasleenKJolly , many thanks for this really valuable feedback.

I believe the colours of hyperlinks was also picked up in the main WIN pages, and I've used the same colour scheme here. Would be a relatively easy one for us to fix quickly with an adjustment to the hex code for the hyperlink colour in the colour scheme style file. Would you be able to share a link to the app you used to identify this problem?

Andrew Galloway will be running these pages through ha full accessibility audit. All heading are formatted with a heading type, and where I've asked around on twitter, GitHub Pages reads well. The main issue I am anticipating for screen readers in in image alt-text, where I've been very thin in the descriptions.

I think both of the points you've highlighted would be good first issues, so I'm going to turn them into a check list below:

  • Change the colour of hyperlinks (?darken) to improve readability.
  • Update the image alternative text to be more descriptive.

@cassgvp cassgvp added the good first issue Good for newcomers label Oct 12, 2020
@JasleenKJolly
Copy link
Author

Fabulous thanks. I use 2 methods to check for colour vision abnormalities. One is an app on my phone called CVSimulator. It allows you use the camera and view any scene with a simulated filter representing the 3 most common forms of inherited colour vision loss.

There is also an add-on for firefox that allows you to do something similar
https://addons.mozilla.org/en-GB/firefox/addon/let-s-get-color-blind/reviews/?utm_source=firefox-browser&utm_medium=firefox-browser&utm_content=addons-manager-reviews-link

@cassgvp cassgvp changed the title Readability Readability - site accessibility report Oct 22, 2020
@cassgvp
Copy link
Owner

cassgvp commented Oct 22, 2020

Andrew has now kindly complete the full accessibility audit. The report is available here. We now need to make a plan for actioning the problem areas identified. This could perhaps be rolled into actioning the accessibility changes for the rest of the WIN pages?

@cassgvp cassgvp changed the title Readability - site accessibility report Readability - action findings of accessibility report Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants