Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DE-7267: HLS-I option to disable intermission #47

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

fingerartur
Copy link
Contributor

Here I'm adding an option to disable intermission of <InterstitialPlayer>.

@fingerartur fingerartur requested a review from doubeka September 9, 2024 14:40
@doubeka
Copy link

doubeka commented Sep 9, 2024

@fingerartur May, why do we need this for IntestitialPlayer? Does this mean we have an option to skip the interstitial?

@fingerartur
Copy link
Contributor Author

Nope. The interstitial player can play the same HLS asset in a loop and the intermission is just a break between two rounds of the loop with a countdown (UI).

@doubeka
Copy link

doubeka commented Sep 9, 2024

@fingerartur Alright, I got it. That makes sense now.

@fingerartur fingerartur merged commit 8f2be54 into main Sep 9, 2024
1 check passed
@fingerartur fingerartur deleted the fix/DE-7267-hls-i-disalbe-intermission branch September 9, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants