Task tool_emailutils\task\update_suppression_list should gracefully fail #53 #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marxjohnson
requested changes
Oct 22, 2024
There was a problem hiding this comment.
Hi Waleed,
Generally this looks like a good solution. Having it disabled by default will prevent errors where it is not being used, and having a debugging message when the configuration is not correct will help diagnose why the task is not working if it is enabled but fails.
Just a few small comments to tidy up.
waleedhassan5
force-pushed
the
aws_suppression_list
branch
from
a3ef213 to
0ebf2be
Compare
marxjohnson
reviewed
Oct 22, 2024
waleedhassan5
force-pushed
the
aws_suppression_list
branch
3 times, most recently
from
d0a702f to
62876a8
Compare
|
@waleedhassan5 Can you always please cross link the issue number in the commit AND in the pull request description so that github does all its nice magic linking. |
waleedhassan5
force-pushed
the
aws_suppression_list
branch
from
62876a8 to
3da3a36
Compare
waleedhassan5
changed the title
waleedhassan5
force-pushed
the
aws_suppression_list
branch
from
3da3a36 to
d0c7fe0
Compare
Sure sorry about that. |
…ail catalyst#53 Fixed an Issue raised about the aws suppression list update so that it doesn't throw any exceptions if it's not enabled and doesn't cause any noise.
waleedhassan5
force-pushed
the
aws_suppression_list
branch
from
d0c7fe0 to
a4f2305
Compare
marxjohnson
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an Issue #53 raised about the aws suppression list update so that it doesn't throw any exceptions if it's not enabled and doesn't cause any noise.