CCTBX tests should not have a phenix dependency

[graeme-winter]

This is inconsistent with the two licenses and thus means that open source users cannot run tests

e89297f

(h/t to @ndevenish for identifcation)

@terwill I think you added this? So would probably be good to have the test data in a cctbx-accessible area or pick a different test file?

This killed our DIALS nightly builds but we have not had a chance until now to find out what killed it...

[terwill]

Hi Graeme, OK, this should be fixed now. Please let me know if not! All the best, Tom T

…

On Fri, Nov 3, 2023 at 3:50 AM Graeme Winter ***@***.***> wrote: This is inconsistent with the two licenses and thus means that open source users cannot run tests e89297f <e89297f> (h/t to @ndevenish <https://github.com/ndevenish> for identifcation) @terwill <https://github.com/terwill> I think you added this? So would probably be good to have the test data in a cctbx-accessible area or pick a different test file? This killed our DIALS nightly builds but we have not had a chance until now to find out what killed it... — Reply to this email directly, view it on GitHub <#935>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AARPZHCL4PI76GQ2DUPPKT3YCS473AVCNFSM6AAAAAA64FHXY2VHI2DSMVQWIX3LMV43ASLTON2WKOZRHE3TKOBQHE4DEOI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Thomas C Terwilliger Laboratory Fellow, Los Alamos National Laboratory Senior Scientist, New Mexico Consortium 100 Entrada Dr, Los Alamos, NM 87544 Email: ***@***.*** Tel: 505-431-0010

[ndevenish]

Hi Tom,

This test is untouched? It looks like you edited a different instance (that we hadn't run into yet!) out of tst_map_model_manager_9_remove_origin_shift_and_unit_cell_crystal_symmetry.py but the original one here tst_reflection_file_editor.py is still failing?

[terwill]

Oh I am sorry, I am out of it. I have now fixed tst_reflection_file_editor.py. Thanks! -Tom T

…

On Mon, Nov 6, 2023 at 7:45 AM Nicholas Devenish ***@***.***> wrote: Hi Tom, This test is untouched? It looks like you edited a different instance (that we hadn't run into yet!) out of tst_map_model_manager_9_remove_origin_shift_and_unit_cell_crystal_symmetry.py <fc6b80f#diff-ea71d82660571b377664d7e224342abba426edb16dc1104611ea5cdd835b37ca> but the original one here tst_reflection_file_editor.py <e89297f#r131627756> is still failing? — Reply to this email directly, view it on GitHub <#935 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AARPZHBMCZ62MT62KAGVIWTYDDZ2DAVCNFSM6AAAAAA64FHXY2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJUHE4TENZVHA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Thomas C Terwilliger Laboratory Fellow, Los Alamos National Laboratory Senior Scientist, New Mexico Consortium 100 Entrada Dr, Los Alamos, NM 87544 Email: ***@***.*** Tel: 505-431-0010

[ndevenish]

Thanks! That looks like it should do it!