Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference config file for Eclair not found #54

Open
s-tikhomirov opened this issue May 28, 2019 · 2 comments
Open

Reference config file for Eclair not found #54

s-tikhomirov opened this issue May 28, 2019 · 2 comments

Comments

@s-tikhomirov
Copy link

I cloned this repo, downloaded Eclair v0.3 jar into the /bin directory, renamed it to eclair.jar, and ran py.test -v test.py.

eclair.py fails on line 62 with:

FileNotFoundError: [Errno 2] No such file or directory: 'src/eclair/eclair-core/src/main/resources/reference.conf'

which is understandable, as lightning-integration doesn't know anything about the Eclair's source code, including its reference configuration file.

I thought I was only supposed to copy the executables into /bin... Other implementations are launched with command line arguments rather than config file. How should I launch this tool with Eclair?

@cdecker
Copy link
Owner

cdecker commented Aug 30, 2019

You need to at least clone the source, so we can extract the config file, adapt it to our needs and then start the binary. We don't ship the config in this repo since it has been rather unstable and breaking our customizations in the past, so we try to grab it from the source repo, matching the version we are about to test.

Notice also that your test-results will not point to the correct versions if you just drop the binaries in the bin/ directory.

It is supposed to be run like this:

make update clients test

That will clone all the repos, update and run the tests.

@s-tikhomirov
Copy link
Author

your test-results will not point to the correct versions if you just drop the binaries in the bin/ directory

I surely misunderstand something, but doesn't it contradict the following phrase from the readme?

In order for the tests to run you'll need to compile the various clients and move/link the binaries into the directories where the tests can find them

Also it might be helpful to mention make update clients test in readme, if that's how this tool is to be used.

(The issue can be closed, as I planned to use this tool for the purpose that is doesn't seem to be well suited for)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants