Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch info in change events #149

Open
xibz opened this issue Jul 24, 2023 · 0 comments
Open

Branch info in change events #149

xibz opened this issue Jul 24, 2023 · 0 comments

Comments

@xibz
Copy link
Contributor

xibz commented Jul 24, 2023

Currently, there's no metadata around branches, without needing to first consume the event, pull out the URL, fetch the information, and then retrieve all that information.

I propose adding a new branch object field in at least the created change event, but could be argued that it should be in every change event.

"branch": {
    "from": "my-fork-branch", # this may need to also support which fork it's coming from, but we can expand on this concept first
    "to": "main"
}

This would include the branch object with two fields: from and to. The idea would be that from is where the change is coming from, and to is where the change is attempting to be merged. From the comment I mentioned we may need to include fork information or something of that nature, but I think starting simple and expanding once we agree on the from and to names and semantics, we can address the fork specification.

I also noticed that id had some examples of featureBranch1234 as the id, but I think we may be overloading the id in this case and it might not be clear, semantically, on what that should be. Instead, by having the branch object, it becomes very clear on what it is and its purpose

@xibz xibz changed the title Branch data in change events Branch info in change events Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant