Version 4.0.3 (#147)

* Fixing #146 Extraneous "None" when remove HDR is selected (thanks to Chad Johnson)
cdgriffith · Dec 30, 2020 · edcbceb · edcbceb
1 parent 0f22dc7
commit edcbceb
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 14 deletions.
diff --git a/CHANGES b/CHANGES
@@ -1,5 +1,9 @@
 # Changelog
 
+## Version 4.0.3
+
+* Fixing #146 Extraneous "None" when remove HDR is selected (thanks to Chad Johnson)
+
 ## Version 4.0.2
 
 * Fixing #144 Remove HDR not working (thanks to Chad Johnson)

diff --git a/fastflix/encoders/common/helpers.py b/fastflix/encoders/common/helpers.py
@@ -206,7 +206,7 @@ def generate_all(
 
 def generate_color_details(fastflix: FastFlix):
     if fastflix.current_video.video_settings.remove_hdr:
-        return
+        return ""
 
     details = []
     if fastflix.current_video.color_primaries:

diff --git a/fastflix/version.py b/fastflix/version.py
@@ -1,4 +1,4 @@
 #!/usr/bin/env python
 # -*- coding: utf-8 -*-
-__version__ = "4.0.2"
+__version__ = "4.0.3"
 __author__ = "Chris Griffith"
diff --git a/fastflix/widgets/main.py b/fastflix/widgets/main.py
@@ -1113,18 +1113,6 @@ def update_video_info(self):
             self.clear_current_video()
             return
 
-        # if self.app.fastflix.current_video.color_space and self.app.fastflix.current_video.color_space not in ffmpeg_valid_color_space:
-        #     logger.warning(f'Unknown color space "{self.app.fastflix.current_video.color_space}", removing')
-        #     self.app.fastflix.current_video.color_space = ""
-        #
-        # if self.app.fastflix.current_video.color_transfer and self.app.fastflix.current_video.color_transfer not in ffmpeg_valid_color_transfers:
-        #     logger.warning(f'Unknown color transfer "{self.app.fastflix.current_video.color_transfer}", removing')
-        #     self.app.fastflix.current_video.color_transfer = ""
-        #
-        # if self.app.fastflix.current_video.color_primaries and self.app.fastflix.current_video.color_primaries not in ffmpeg_valid_color_primaries:
-        #     logger.warning(f'Unknown color primaries "{self.app.fastflix.current_video.color_primaries}", removing')
-        #     self.app.fastflix.current_video.ffmpeg_valid_color_primaries = ""
-
         text_video_tracks = [
             f'{x.index}: {t("codec")} {x.codec_name} - {x.get("pix_fmt")} - {t("profile")} {x.get("profile")}'
             for x in self.app.fastflix.current_video.streams.video