Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add_hips: Create an ImageSurvey/Image object and allow to set its opacity, colormap, ... #76

Open
Tracked by #45
ManonMarchand opened this issue Apr 12, 2024 · 4 comments · May be fixed by #84
Open
Tracked by #45

add_hips: Create an ImageSurvey/Image object and allow to set its opacity, colormap, ... #76

ManonMarchand opened this issue Apr 12, 2024 · 4 comments · May be fixed by #84
Milestone
1.0.0

Comments

@ManonMarchand
Copy link
Member

ManonMarchand commented Apr 12, 2024 •
edited
Loading

Openend this issue from the last point of #45
@ManonMarchand ManonMarchand mentioned this issue Apr 12, 2024
Closed
4 tasks
@ManonMarchand
Copy link
Member Author

To implement this:

  • create python obfject for hips with all options (dataclass?)
  • or see if this could be generic (no code duplication)

@bmatthieu3
Copy link
Collaborator

See this JS HiPS instanciation method imageHiPS

@bmatthieu3
Copy link
Collaborator

I guess that for starting we do not need to have an object, just a

aladin.add_hips(url/id, options)

is sufficient to begin. It will not be possible to remove the newly added HiPS. For that we could impl something similar than for overlays described in #78
It is also possible to remove the HiPS/overlays from the UI

@bmatthieu3
Copy link
Collaborator

We could deprecate these Aladin properties: overlay_survey and overlay_survey_opacity

@ManonMarchand ManonMarchand added this to the 0.4 milestone Apr 15, 2024
@Xen0Xys Xen0Xys linked a pull request Apr 25, 2024 that will close this issue
Draft
@ManonMarchand ManonMarchand changed the title Create an ImageSurvey/Image object and allow to set its opacity, colormap, ... add_hips: Create an ImageSurvey/Image object and allow to set its opacity, colormap, ... May 16, 2024
@ManonMarchand ManonMarchand modified the milestones: 0.5, 1.0.0 Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

feat: layers manipulations Xen0Xys/ipyaladin
2 participants
@bmatthieu3 @ManonMarchand