Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

non-constant format string in call to cosmossdk.io/errors.Wrapf #3919

Closed
rootulp opened this issue Sep 26, 2024 · 1 comment · Fixed by #3924
Closed

non-constant format string in call to cosmossdk.io/errors.Wrapf #3919

rootulp opened this issue Sep 26, 2024 · 1 comment · Fixed by #3924
Assignees
@kobakaku
Labels
good first issue Good for newcomers nice to have item is not blocking or required.

Comments

@rootulp
Copy link
Collaborator

rootulp commented Sep 26, 2024

Problem

On v2.x

$ make lint
--> Running golangci-lint
WARN The linter 'exportloopref' is deprecated (since v1.60.2) due to: Since Go1.22 (loopvar) this linter is no longer relevant. Replaced by copyloopvar.
x/blobstream/keeper/keeper_data_commitment.go:112:78: printf: non-constant format string in call to cosmossdk.io/errors.Wrapf (govet)
			return types.DataCommitment{}, errors.Wrapf(types.ErrAttestationNotFound, fmt.Sprintf("nonce %d", i))
			                                                                          ^
x/blobstream/keeper/keeper_data_commitment.go:139:61: printf: non-constant format string in call to cosmossdk.io/errors.Wrapf (govet)
			return false, errors.Wrapf(types.ErrAttestationNotFound, fmt.Sprintf("nonce %d", i))

Proposal

Address the lint complaints
@rootulp rootulp added good first issue Good for newcomers nice to have item is not blocking or required. labels Sep 26, 2024
This was referenced Sep 30, 2024
Closed
Closed
Merged
@kobakaku
Copy link
Contributor

I've done this issue.
#3924

mergify bot pushed a commit that referenced this issue Sep 30, 2024
@kobakaku @mergify
fix(lint): golang-client lint errors (#3924)
9bdce38 
<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->
Closes #3919
## Overview

<!--
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue.
-->
Fix the lint errors of golangci-lint.
Merge this [PR](#3923)
to this branch.

(cherry picked from commit 363a8c5)
@mergify mergify bot mentioned this issue Sep 30, 2024
Merged
rootulp added a commit that referenced this issue Oct 14, 2024
@mergify @kobakaku @rootulp
fix(lint): golang-client lint errors (backport #3924) (#3925)
c11eeb3 
Closes #3919
## Overview


Fix the lint errors of golangci-lint.
Merge this [PR](#3923)
to this branch.<hr>This is an automatic backport of pull request #3924
done by [Mergify](https://mergify.com).

---------

Co-authored-by: kobakaku <[email protected]>
Co-authored-by: Rootul P <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kobakaku kobakaku

Labels
good first issue Good for newcomers nice to have item is not blocking or required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(lint): golang-client lint errors kobakaku/celestia-app
2 participants
@rootulp @kobakaku