Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert using a commit in the MajorUpgradeToV3 #3981

Closed
evan-forbes opened this issue Oct 16, 2024 · 1 comment
Closed

Revert using a commit in the MajorUpgradeToV3 #3981

evan-forbes opened this issue Oct 16, 2024 · 1 comment
Assignees
@evan-forbes
Labels
flup nice to have item is not blocking or required. WS: Maintenance 🔧 includes bugs, refactors, flakes, and tech debt etc WS: V3 3️⃣ item is directly relevant to the v3 hardfork

Comments

@evan-forbes
Copy link
Member 

          LGTM

Can we just create a follow up issue to fix the v3 upgrade test such that we don't need a fixed commit tag

Originally posted by @cmwaters in #3882 (review)
@evan-forbes evan-forbes added WS: Maintenance 🔧 includes bugs, refactors, flakes, and tech debt etc nice to have item is not blocking or required. WS: V3 3️⃣ item is directly relevant to the v3 hardfork flup and removed needs:triage labels Oct 16, 2024
@evan-forbes evan-forbes self-assigned this Oct 16, 2024
@evan-forbes evan-forbes mentioned this issue Oct 16, 2024
Merged
@rootulp
Copy link
Collaborator

rootulp commented Oct 16, 2024

Can close this as a duplicate of #3947

@rootulp rootulp closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evan-forbes evan-forbes

Labels
flup nice to have item is not blocking or required. WS: Maintenance 🔧 includes bugs, refactors, flakes, and tech debt etc WS: V3 3️⃣ item is directly relevant to the v3 hardfork
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rootulp @evan-forbes