Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Cleanup CrowdloanClaim and CrowdloanReward storage (requires Polkadot SDK v1.9.0+) #1836

Open
wischli opened this issue May 13, 2024 · 0 comments
Open

Chore: Cleanup CrowdloanClaim and CrowdloanReward storage (requires Polkadot SDK v1.9.0+) #1836

wischli opened this issue May 13, 2024 · 0 comments
Labels
D8-migration Pull request touches storage and needs migration code. I11-cleaning No mandatory issue that leave the repo more readable/organized P2-nice-to-have Issue is worth doing.

Comments

@wischli
Copy link
Contributor

wischli commented May 13, 2024

Description

After upgrading to Polkadot SDK v1.9.0+, use Multiblock migrations to cleanup the following pallets which have already been removed:

  • CrowdloanClaim
  • CrowdloanReward

Research/based on

How will this affect the code base

  • Onchain storage will be reduced

What are foreseen obstacles or hurdles to overcome?

  • Keeping dead storage does not impose security risk
  • Requires multi block migration
@wischli wischli added P2-nice-to-have Issue is worth doing. D8-migration Pull request touches storage and needs migration code. I11-cleaning No mandatory issue that leave the repo more readable/organized labels May 13, 2024
@wischli wischli changed the title Clean Chore: Cleanup CrowdloanClaim and CrowdloanReward storage (requires Polkadot SDK v1.9.0+) May 13, 2024
@wischli wischli mentioned this issue May 13, 2024
Merged
5 tasks
@lemunozm lemunozm mentioned this issue May 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
D8-migration Pull request touches storage and needs migration code. I11-cleaning No mandatory issue that leave the repo more readable/organized P2-nice-to-have Issue is worth doing.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wischli