e2e: add timeout for pvc deletion in ephemeral e2e #4058
Conversation
|
/test ci/centos/mini-e2e-helm/k8s-1.27 |
|
/test ci/centos/mini-e2e-helm/k8s-1.27 |
1 similar comment
|
/test ci/centos/mini-e2e-helm/k8s-1.27 |
| if isRetryableAPIError(err) { | ||
| framework.Logf("failed to verify deletion of PVC %s (status: %s): %v", pvcName, pvc.Status, err) | ||
|
|
||
| return false, nil | ||
| } | ||
| if !apierrs.IsNotFound(err) { | ||
| return false, fmt.Errorf("get on deleted PVC %v failed with error other than \"not found\": %w", pvcName, err) | ||
| } | ||
|
|
||
| // PVC has been successfully deleted | ||
| return true, nil |
There was a problem hiding this comment.
@riya-singhal31 Can you please check your logic flow here again?
This part of the code will never be executed since both err != nil and err == nil conditions are checked above and a exit from loop occurs.
There was a problem hiding this comment.
Thanks Rakshith for reviewing.
Updated, Can you please have a re-look.
|
@Mergifyio queue |
🛑 The pull request rule doesn't match anymoreThis action has been cancelled. |
e2e/cephfs.go
Outdated
| @@ -399,6 +399,13 @@ var _ = Describe(cephfsType, func() { | |||
| if err != nil { | |||
| framework.Failf("failed to delete application: %v", err) | |||
| } | |||
|
|
|||
| // wait for the associated PVC to be deleted | |||
| err = waitForPVCToBeDeleted(f.ClientSet, app.Namespace, "mypvc", deployTimeout) | |||
There was a problem hiding this comment.
lets not pass the hardcoded pvc name, read it from the app pod
There was a problem hiding this comment.
Thanks Madhu, done. PTAL
e2e/rbd.go
Outdated
| @@ -817,6 +817,13 @@ var _ = Describe("RBD", func() { | |||
| if err != nil { | |||
| framework.Failf("failed to delete application: %v", err) | |||
| } | |||
|
|
|||
| // wait for the associated PVC to be deleted | |||
| err = waitForPVCToBeDeleted(f.ClientSet, app.Namespace, "mypvc", deployTimeout) | |||
There was a problem hiding this comment.
lets not pass the hardcoded pvc name, read it from the app pod
There was a problem hiding this comment.
Thanks @Madhu-1, done. PTAL
mergify
bot
dismissed stale reviews from nixpanic and Rakshith-R
Pull request has been modified.
|
/test ci/centos/mini-e2e-helm/k8s-1.27 |
1 similar comment
|
/test ci/centos/mini-e2e-helm/k8s-1.27 |
|
@Mergifyio queue |
🛑 The pull request has been removed from the queue
|
|
/test ci/centos/k8s-e2e-external-storage/1.27 |
|
/test ci/centos/mini-e2e-helm/k8s-1.27 |
|
/test ci/centos/k8s-e2e-external-storage/1.26 |
|
/test ci/centos/mini-e2e/k8s-1.27 |
|
/test ci/centos/mini-e2e-helm/k8s-1.26 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/mini-e2e/k8s-1.26 |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/k8s-e2e-external-storage/1.28 |
|
/test ci/centos/mini-e2e-helm/k8s-1.28 |
|
/test ci/centos/mini-e2e/k8s-1.28 |
|
Add a comment |
|
@Mergifyio rebase |
this commit adds the timeout to wait for pvc deletion after the deletion of pod in test. Signed-off-by: riya-singhal31 <[email protected]>
✅ Branch has been successfully rebased |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/k8s-e2e-external-storage/1.26 |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/k8s-e2e-external-storage/1.27 |
|
/test ci/centos/mini-e2e-helm/k8s-1.26 |
|
/test ci/centos/k8s-e2e-external-storage/1.28 |
|
/test ci/centos/mini-e2e/k8s-1.26 |
|
/test ci/centos/mini-e2e-helm/k8s-1.27 |
|
/test ci/centos/mini-e2e-helm/k8s-1.28 |
|
/test ci/centos/mini-e2e/k8s-1.27 |
|
/test ci/centos/mini-e2e/k8s-1.28 |
|
/test ci/centos/mini-e2e/k8s-1.25 |
|
/test ci/centos/mini-e2e-helm/k8s-1.25 |
|
/test ci/centos/k8s-e2e-external-storage/1.25 |
nixpanic
added
the
ci/skip/multi-arch-build
this commit adds the timeout to wait for pvc
deletion after the deletion of pod in a test.
fixes: #3910